Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix stats_overview_type_tapped event #20342

Merged
merged 5 commits into from
Feb 29, 2024
Merged

Fix stats_overview_type_tapped event #20342

merged 5 commits into from
Feb 29, 2024

Conversation

irfano
Copy link
Member

@irfano irfano commented Feb 29, 2024 •
edited by ravishanker
Loading

Fixes #20313

This fixes the wrong event when changing the columns on the traffic tab.

To Test:

  1. Enable Stats Traffic feature flag
  2. Open Stats
  3. Open Traffic
  4. Select By Week, Month or Year period
  5. Change between views/visitors/comments/likes
  6. Verify that 🔵 Tracked: stats_overview_type_tapped_comments, Properties: {"period":"years"} is logged with the granularity and event name. You can check Logcat if you build from Android Studio or "Me → Help → Logs".
  7. Repeat the test with disabled flag and verify the tracks switching between Views/Visitors/Likes/Comments

Regression Notes

  1. Potential unintended areas of impact

    • None

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    • N/A

  3. What automated tests I added (or what prevented me from doing so)

    • We don't have test cases for stats usecases. Since we may change the stats architecture soon, I'm skipping adding tests here.

PR Submission Checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing Checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • Talkback.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • Large and small screen sizes. (Tablet and smaller phones)
  • Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

@irfano irfano added this to the 24.4 milestone Feb 29, 2024
@irfano irfano requested a review from ravishanker February 29, 2024 19:20
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is assigned to the milestone 24.4. This milestone is due in less than 4 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

@irfano irfano changed the title Issue/20313 fix stats overview type tapped event Fix stats_overview_type_tapped event Feb 29, 2024
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Feb 29, 2024 •
edited
Loading

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr20342-7c2b0dc
Commit7c2b0dc
Direct Downloadjetpack-prototype-build-pr20342-7c2b0dc.apk
 Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Feb 29, 2024 •
edited
Loading

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr20342-7c2b0dc
Commit7c2b0dc
Direct Downloadwordpress-prototype-build-pr20342-7c2b0dc.apk
 Note: Google Login is not supported on these builds.

ravishanker
ravishanker approved these changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@ravishanker ravishanker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 🚀

🔵 Tracked: stats_overview_type_tapped_visitors, Properties: {"period":"weeks"}
🔵 Tracked: stats_overview_type_tapped_likes, Properties: {"period":"weeks"}
🔵 Tracked: stats_overview_type_tapped_comments, Properties: {"period":"weeks"}
🔵 Tracked: stats_overview_type_tapped_views, Properties: {"period":"weeks"}

@ravishanker
Copy link
Contributor

Fixed detekt warnings in 7c2b0dc

@codecov Codecov
Copy link

codecov bot commented Feb 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 40.25%. Comparing base (7a4c7f7) to head (7c2b0dc).
Report is 25 commits behind head on trunk.

Files Patch % Lines
...ists/sections/granular/usecases/OverviewUseCase.kt 0.00% 7 Missing ⚠️
...h/lists/sections/traffic/TrafficOverviewUseCase.kt 0.00% 7 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##            trunk   #20342      +/-   ##
==========================================
- Coverage   40.25%   40.25%   -0.01%     
==========================================
  Files        1475     1475              
  Lines       68105    68113       +8     
  Branches    11295    11299       +4     
==========================================
  Hits        27416    27416              
- Misses      38180    38188       +8     
  Partials     2509     2509

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ravishanker ravishanker merged commit 1f30dda into trunk Feb 29, 2024
20 checks passed
@ravishanker ravishanker deleted the issue/20313-fix-stats-overview-type-tapped-event branch February 29, 2024 23:56
@irfano irfano added the Stats label Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ravishanker ravishanker ravishanker approved these changes

Assignees
No one assigned
Labels
Analytics Stats [Type] Bug
Projects
None yet
Milestone
24.4
Development

Successfully merging this pull request may close these issues.

Stats Traffic: Views/Visitors/Comments/Likes tracked incorrectly
4 participants
@irfano @dangermattic @wpmobilebot @ravishanker